Re: [PATCH bpf-next v2 0/9] Introduce load-acquire and store-release BPF instructions
From: Peilin Ye
Date: Fri Feb 07 2025 - 16:30:09 EST
On Fri, Feb 07, 2025 at 02:04:54AM +0000, Peilin Ye wrote:
> Peilin Ye (9):
> bpf/verifier: Factor out atomic_ptr_type_ok()
> bpf/verifier: Factor out check_atomic_rmw()
> bpf/verifier: Factor out check_load_mem() and check_store_reg()
> bpf: Introduce load-acquire and store-release instructions
> arm64: insn: Add BIT(23) to {load,store}_ex's mask
> arm64: insn: Add load-acquire and store-release instructions
> bpf, arm64: Support load-acquire and store-release instructions
> selftests/bpf: Add selftests for load-acquire and store-release
> instructions
> bpf, docs: Update instruction-set.rst for load-acquire and
> store-release instructions
>
> .../bpf/standardization/instruction-set.rst | 114 ++++++--
> arch/arm64/include/asm/insn.h | 12 +-
> arch/arm64/lib/insn.c | 29 ++
> arch/arm64/net/bpf_jit.h | 20 ++
> arch/arm64/net/bpf_jit_comp.c | 87 +++++-
> arch/s390/net/bpf_jit_comp.c | 14 +-
> arch/x86/net/bpf_jit_comp.c | 4 +
> include/linux/bpf.h | 11 +
> include/linux/filter.h | 2 +
> include/uapi/linux/bpf.h | 13 +
> kernel/bpf/core.c | 63 ++++-
> kernel/bpf/disasm.c | 12 +
> kernel/bpf/verifier.c | 234 +++++++++++-----
> tools/include/uapi/linux/bpf.h | 13 +
> .../selftests/bpf/prog_tests/arena_atomics.c | 50 ++++
> .../selftests/bpf/prog_tests/verifier.c | 4 +
> .../selftests/bpf/progs/arena_atomics.c | 88 ++++++
> .../bpf/progs/verifier_load_acquire.c | 190 +++++++++++++
> .../selftests/bpf/progs/verifier_precision.c | 47 ++++
> .../bpf/progs/verifier_store_release.c | 262 ++++++++++++++++++
> 20 files changed, 1164 insertions(+), 105 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/progs/verifier_load_acquire.c
> create mode 100644 tools/testing/selftests/bpf/progs/verifier_store_release.c
Looks like the llvm-18 CI job passed but the llvm-17/gcc ones failed.
I'll debug with llvm-17 and see if I need different #ifdef guards for
the new tests.
Thanks,
Peilin Ye