Re: [PATCH v7 03/24] perf vendor events: Add Arrowlake events/metrics

[Ian Rogers]

On Fri, Feb 7, 2025 at 12:44 PM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
>
>
>
> On 2025-02-07 1:51 p.m., Ian Rogers wrote:
> > +    {
> > +        "BriefDescription": "Percentage of time that the core is stalled due to a TPAUSE or UMWAIT instruction",
> > +        "MetricExpr": "100 * cpu_atom@SERIALIZATION.C01_MS_SCB@ / (8 * cpu_atom@CPU_CLK_UNHALTED.CORE@)",
> > +        "MetricName": "tma_info_serialization _%_tpause_cycles",
>
> It doesn't seem a correct MetricName. A convert script bug?

They come from the E-core_TMA_Metrics.csv line 91:
https://github.com/captain5050/perfmon/blob/main/E-core_TMA_Metrics.csv
Info.Serialization %_Tpause_Cycles 100 * SERIALIZATION.C01_MS_SCB /
#SLOTS 100 * SERIALIZATION.C01_MS_SCB / #SLOTS 100 *
SERIALIZATION.C01_MS_SCB / #SLOTS 100 * SERIALIZATION.C01_MS_SCB /
#SLOTS Percentage of time that the core is stalled due to a TPAUSE or
UMWAIT instruction

The % works okay in the metric name but we could swap it if you want.

Thanks,
Ian

> > +        "Unit": "cpu_atom"
> > +    },diff --git a/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json b/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json
> > new file mode 100644
> > index 000000000000..1ac5b5ef8094
> > --- /dev/null
> > +++ b/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json
> > @@ -0,0 +1,10 @@
> > +[
> > +    {
> > +        "BriefDescription": "This 48-bit fixed counter counts the UCLK cycles.",
> > +        "Counter": "FIXED",
> > +        "EventCode": "0xff",
> > +        "EventName": "UNC_CLOCK.SOCKET",
> > +        "PerPkg": "1",
> > +        "Unit": "CLOCK"
>
> On MTL and ARL, the unit should be CNCU.
> Thomas will propose a convertor script patch to fix it.
>
> Thanks,
> Kan
>
> > +    }
> > +]
>