Re: [PATCH 2/2] dt-bindings: memory-controllers: Add mediatek common-dramc dt-bindings
From: Crystal Guo (郭晶)
Date: Fri Feb 07 2025 - 23:24:21 EST
On Thu, 2024-12-12 at 04:27 -0600, Rob Herring (Arm) wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Thu, 12 Dec 2024 16:59:48 +0800, Crystal Guo wrote:
> > Add devicetree binding for mediatek common-dramc driver.
> >
> > The DRAM controller of MediaTek SoC provides an interface to
> > get the current data rate of DRAM.
> >
> > Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx>
> > ---
> > .../mediatek,common-dramc.yaml | 129
> > ++++++++++++++++++
> > 1 file changed, 129 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/memory-
> > controllers/mediatek,common-dramc.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: support-ch-cnt: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: fmeter-version: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: crystal-freq: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: shu-of: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: pll-id: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: shu-lv: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: sdmpcw: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: posdiv: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: fbksel: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: dqsopen: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: async-ca: missing type
> definition
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/memory-
> controllers/mediatek,common-dramc.yaml: dq-ser-mode: missing type
> definition
>
> doc reference errors (make refcheckdocs):
>
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241212090029.13692-3-crystal.guo@xxxxxxxxxxxx
>
> The base for the series is generally the latest rc1. A different
> dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself.
> Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up
> checking
> your schema. However, it must be unset to test all examples with your
> schema.
>
Thank you for the reminder.
Fix the build error on v2:https://patchwork.kernel.org/patch/13964209
Thanks
Crystal