Re: [PATCH v7 03/24] perf vendor events: Add Arrowlake events/metrics

[Ian Rogers]

On Fri, Feb 7, 2025 at 5:19 PM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
>
> On 2025-02-07 6:00 p.m., Ian Rogers wrote:
> > On Fri, Feb 7, 2025 at 12:44 PM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> >>
> >>
> >> On 2025-02-07 1:51 p.m., Ian Rogers wrote:
> >>> +    {
> >>> +        "BriefDescription": "Percentage of time that the core is stalled due to a TPAUSE or UMWAIT instruction",
> >>> +        "MetricExpr": "100 * cpu_atom@SERIALIZATION.C01_MS_SCB@ / (8 * cpu_atom@CPU_CLK_UNHALTED.CORE@)",
> >>> +        "MetricName": "tma_info_serialization _%_tpause_cycles",
> >> It doesn't seem a correct MetricName. A convert script bug?
> > They come from the E-core_TMA_Metrics.csv line 91:
> > https://github.com/captain5050/perfmon/blob/main/E-core_TMA_Metrics.csv
> > Info.Serialization %_Tpause_Cycles 100 * SERIALIZATION.C01_MS_SCB /
> > #SLOTS 100 * SERIALIZATION.C01_MS_SCB / #SLOTS 100 *
> > SERIALIZATION.C01_MS_SCB / #SLOTS 100 * SERIALIZATION.C01_MS_SCB /
> > #SLOTS Percentage of time that the core is stalled due to a TPAUSE or
> > UMWAIT instruction
> >
> > The % works okay in the metric name but we could swap it if you wan
>
> Yes, the % works, but there is a space between tma_info_serialization
> and _%_tpause_cycles.
>
> I'm not sure if it's an issue of E-core_TMA_Metrics.csv or the convertor
> script.

The space was in the CSV file but the converter shouldn't have passed
it through. I've sent a fix:
https://github.com/intel/perfmon/pull/286
I'll send v8 when Thomas fixes the E-core units.

Thanks,
Ian