Re: [PATCH] drm/panel: visionox-r66451: transition to mipi_dsi wrapped functions

[Dmitry Baryshkov]

On Sat, Feb 08, 2025 at 10:45:41AM +0530, Tejas Vipin wrote:
> Change the visionox-r66451 panel to use multi style functions for 
> improved error handling.
> 
> Signed-off-by: Tejas Vipin <tejasvipin76@xxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-visionox-r66451.c | 179 ++++++++----------
>  1 file changed, 76 insertions(+), 103 deletions(-)
> 
> @@ -187,25 +181,13 @@ static int visionox_r66451_enable(struct drm_panel *panel)
>  	}
>  
>  	drm_dsc_pps_payload_pack(&pps, dsi->dsc);
> -	ret = mipi_dsi_picture_parameter_set(dsi, &pps);
> -	if (ret) {
> -		dev_err(&dsi->dev, "Failed to set PPS\n");
> -		return ret;
> -	}
> +	mipi_dsi_picture_parameter_set_multi(&dsi_ctx, &pps);
>  
> -	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> -	if (ret < 0) {
> -		dev_err(&dsi->dev, "Failed to exit sleep mode: %d\n", ret);
> -		return ret;
> -	}
> -	msleep(120);
> +	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
> +	mipi_dsi_msleep(&dsi_ctx, 120);
>  
> -	ret = mipi_dsi_dcs_set_display_on(dsi);
> -	if (ret < 0) {
> -		dev_err(&dsi->dev, "Failed on set display on: %d\n", ret);
> -		return ret;
> -	}
> -	msleep(20);
> +	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
> +	mipi_dsi_msleep(&dsi_ctx, 20);
>  
>  	return 0;

return dsi_ctx.accum_err;

>  }

-- 
With best wishes
Dmitry