Re: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver

From: Markus Elfring
Date: Sat Feb 08 2025 - 10:31:43 EST



> +++ b/drivers/firmware/samsung/exynos-acpm.c
> @@ -0,0 +1,771 @@

> +static int acpm_dequeue_by_polling(struct acpm_chan *achan,
> + const struct acpm_xfer *xfer)
> +{

> + do {
> + mutex_lock(&achan->rx_lock);
> + ret = acpm_get_rx(achan, xfer);
> + mutex_unlock(&achan->rx_lock);


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&achan->rx_lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/mutex.h#L201

Regards,
Markus