Re: [PATCH v4 0/3] Re-add filter_type/filter_mode

[Jonathan Cameron]

On Tue, 4 Feb 2025 12:00:16 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:

> Better document sysfs ABI for ADC digital filter configuration.
> Also update ad4130 driver to support the standardized IIO ABI for digital filter
> configuration.
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan

> 
> Change log v3 -> v4
> - Renamed in_voltage-voltage_filter_mode_available to
>   in_voltage-voltage_filter_type_available instead of just removing the mode
>   variant from sysfs-bus-iio.
> - Added comment about backwards compatibility near ad4130 filter attribute
>   declarations.
> - Reordered patches so attributes are documented before use.
> - Minor re-word of in_voltage-voltage_filter_mode_available text in
>   sysfs-bus-iio-adc-ad4130 to make it more generic.
> - Picked up review tags.
> 
> Change log v2 -> v3
> - Added in_voltageY-voltageZ_filter_type to main IIO ADI doc too.
> - Added filter_type attributes to ad4130 driver so it also supports the
>   standardized ABI for digital filter configuration.
> - No longer dropping AD4130 specific filter_type_available options from sysfs-bus-iio.
> - Re-add sysfs-bus-iio-adc-ad4130 just mentioning the ABI at sysfs-bus-iio instead
>   of repeating the doc.
> 
> Change log v1 -> v2
> - Split into 3 patches.
> - Re-added sysfs-bus-iio-adc-ad4130 to keep filter_mode separate from filter_type.
> - Removed in_voltage-voltage_filter_mode_available from sysfs-bus-iio.
> - Added deprecation notes in sysfs-bus-iio-adc-ad4130 asking to use filter_type
>   for new drivers and referencing sysfs-bus-iio.
> - Improved commit message with explanation about use of filter type attributes.
> - Dropped AD4130 specific filter_type_available options from sysfs-bus-iio.
> 
> Link to v1: https://lore.kernel.org/linux-iio/b2132bd3ca1d64cdd8d5afab1f1f33c574718b50.1732901318.git.marcelo.schmitt@xxxxxxxxxx/
> Link to v2: https://lore.kernel.org/linux-iio/cover.1736261047.git.marcelo.schmitt@xxxxxxxxxx/
> Link to v3: https://lore.kernel.org/linux-iio/cover.1738608986.git.marcelo.schmitt@xxxxxxxxxx/
> 
> 
> Marcelo Schmitt (3):
>   Documentation: ABI: IIO: Add filter_type documentation
>   Documentation: ABI: IIO: Re-add sysfs-bus-iio-adc-ad4130
>   iio: adc: ad4130: Add filter_type attributes
> 
>  Documentation/ABI/testing/sysfs-bus-iio       | 10 +++++++++-
>  .../ABI/testing/sysfs-bus-iio-adc-ad4130      | 20 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  drivers/iio/adc/ad4130.c                      |  7 +++++++
>  4 files changed, 37 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130
> 
> 
> base-commit: 9b75dd1b7d6b98699a104c6b1eec0c8817e5fd4b