Re: [PATCH v2] intel_idle: introduce 'no_native' module parameter

From: David Arcari
Date: Sat Feb 08 2025 - 14:56:20 EST




On 2/8/25 5:37 AM, Artem Bityutskiy wrote:
On Fri, 2025-02-07 at 12:13 -0500, David Arcari wrote:
And if kernel was not configured with ACPI support, are these not
recognized? Or
they are just no-op basically?

They are a no-op - the flags are all set to false so ACPI C-state tables
are ignored.

It would be nice to mention this too. Otherwise it sounds a bit incomplete. Like
this:

If A then B. (nothing about "else").

Better way:

If A then B, else C.

:-)

I actually took that from what was already there.

So I can add "In the case that ACPI is not configured these flags have no impact on functionality."

Does that work?

-DA



Sure - so is this better:

``use_acpi`` - No-op in ACPI mode, the driver will consult ACPI tabees
for C-states on/off status in native mode.

Yes, thanks!