Re: [PATCH v2 06/35] drm/atomic-helper: Fix commit_tail state variable name

From: Dmitry Baryshkov
Date: Sat Feb 08 2025 - 20:21:07 EST


On Tue, Feb 04, 2025 at 03:57:34PM +0100, Maxime Ripard wrote:
> Even though the commit_tail () drm_atomic_state parameter is called
> old_state, it's actually the state being committed which is confusing.
>
> It's even more confusing since the atomic_commit_tail hook being called
> by commit_tail() parameter is called state.
>
> Let's rename the variable from old_state to state to make it less
> confusing.
>
> Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>

--
With best wishes
Dmitry