Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Chunfeng Yun (云春峰)]

On Mon, 2025-01-13 at 18:30 +0000, Conor Dooley wrote:
> On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> > Add a property to tune usb2 phy's disconnect threshold.
> > And add a compatible for mt8196.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > ---
> > based on kernel 6.13-rc1
> > 
> > this property is porting from t-phy driver, due to the u2 phy are
> > similar.
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8
> > ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > index a9e3139fd421..2e012d5e1da1 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > @@ -49,6 +49,7 @@ properties:
> >        - enum:
> >            - mediatek,mt3611-xsphy
> >            - mediatek,mt3612-xsphy
> > +          - mediatek,mt8196-xsphy
> >        - const: mediatek,xsphy
> >  
> >    reg:
> > @@ -129,6 +130,13 @@ patternProperties:
> >          minimum: 1
> >          maximum: 7
> >  
> > +      mediatek,discth:
> > +        description:
> > +          The selection of disconnect threshold (U2 phy)
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        minimum: 1
> > +        maximum: 15
> 
> What unit is this? Unitless? How are the values determined?
No unit, it's a level, may be treat it as an index to select different
threshold.

Thanks
> 
> > +
> >        mediatek,efuse-intr:
> >          description:
> >            The selection of Internal Resistor (U2/U3 phy)
> > -- 
> > 2.46.0
> >