[PATCH 2/2] HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set default brightness

From: Aditya Garg
Date: Sun Feb 09 2025 - 02:28:06 EST


From: Aditya Garg <gargaditya08@xxxxxxxx>

This commit makes use of appletb_bl_brightness_map instead of using if
statements and magic numbers to set default brightness, and thus simplifies
the code.

Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
---
drivers/hid/hid-appletb-bl.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c
index 819157686..1a3dcd44b 100644
--- a/drivers/hid/hid-appletb-bl.c
+++ b/drivers/hid/hid-appletb-bl.c
@@ -141,12 +141,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id
bl->aux1_field = aux1_field;
bl->brightness_field = brightness_field;

- if (appletb_bl_def_brightness == 0)
- ret = appletb_bl_set_brightness(bl, APPLETB_BL_OFF);
- else if (appletb_bl_def_brightness == 1)
- ret = appletb_bl_set_brightness(bl, APPLETB_BL_DIM);
- else
- ret = appletb_bl_set_brightness(bl, APPLETB_BL_ON);
+ ret = appletb_bl_set_brightness(bl,
+ appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]);

if (ret) {
dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n");
--
2.43.0