Re: [PATCH v4 10/14] arm64: Add KHO support

[Krzysztof Kozlowski]

On 06/02/2025 14:27, Mike Rapoport wrote:
> From: Alexander Graf <graf@xxxxxxxxxx>
> 
> We now have all bits in place to support KHO kexecs. This patch adds


Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> awareness of KHO in the kexec file as well as boot path for arm64 and
> adds the respective kconfig option to the architecture so that it can
> use KHO successfully.
> 
> Signed-off-by: Alexander Graf <graf@xxxxxxxxxx>
> Co-developed-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> ---


...

> +#ifdef CONFIG_KEXEC_HANDOVER
> +	dt = image->kho.dt.buffer;
> +	dt_mem = image->kho.dt.mem;
> +	dt_len = image->kho.dt.bufsz;
> +
> +	scratch_mem = image->kho.scratch.mem;
> +	scratch_len = image->kho.scratch.bufsz;
> +#endif
> +
> +	if (!dt)
> +		goto out;
> +
> +	pr_debug("Adding kho metadata to DT");
> +
> +	ret = fdt_appendprop_addrrange(fdt, 0, chosen_node, "linux,kho-dt",

Where is the ABI documentation for this?

> +				       dt_mem, dt_len);
> +	if (ret)
> +		goto out;
> +
> +	ret = fdt_appendprop_addrrange(fdt, 0, chosen_node, "linux,kho-scratch",

Same question.

> +				       scratch_mem, scratch_len);
> +	if (ret)
> +		goto out;
> +
Best regards,
Krzysztof