Re: [PATCH v3 RESEND 0/2] Device Tree for Apple T2 (T8012) SoC devices

[Neal Gompa]

On Mon, Feb 3, 2025 at 6:45 AM Nick Chan <towinchenmi@xxxxxxxxx> wrote:
>
> This series adds device trees for the Apple T2 Security Chip found on
> some Intel Macs released after 2017. This SoC is based on Apple A10
> (T8010) SoC and, for many hardware blocks, can share the A10 compatibles.
>
> Changes since v2:
> - Drop PMGR nodes, moved to PMGR nodes for A7-A11, T2 SoC series.
>
> Link to v2: https://lore.kernel.org/asahi/20241203051147.110980-1-towinchenmi@xxxxxxxxx/T
>
> Changes since v1:
> - Use imperative mood in commit messages
>
> Link to v1: https://lore.kernel.org/asahi/20241201161942.36027-1-towinchenmi@xxxxxxxxx/T
>
> [1]: https://lore.kernel.org/asahi/20241203050640.109378-1-towinchenmi@xxxxxxxxx/T
>
> Nick Chan
>
> Cc: Aun-Ali Zaidi <admin@xxxxxxxxxx>
>
> ---
> Nick Chan (2):
>   dt-bindings: arm: apple: Add T2 devices
>   arm64: dts: apple: Add T2 devices
>
>  .../devicetree/bindings/arm/apple.yaml        |  41 ++++
>  arch/arm64/boot/dts/apple/Makefile            |  16 ++
>  arch/arm64/boot/dts/apple/t8012-j132.dts      |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j137.dts      |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j140a.dts     |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j140k.dts     |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j152f.dts     |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j160.dts      |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j174.dts      |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j185.dts      |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j185f.dts     |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j213.dts      |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j214k.dts     |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j215.dts      |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j223.dts      |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j230k.dts     |  14 ++
>  arch/arm64/boot/dts/apple/t8012-j680.dts      |  15 ++
>  arch/arm64/boot/dts/apple/t8012-j780.dts      |  15 ++
>  arch/arm64/boot/dts/apple/t8012-jxxx.dtsi     |  44 +++++
>  arch/arm64/boot/dts/apple/t8012-touchbar.dtsi |  19 ++
>  arch/arm64/boot/dts/apple/t8012.dtsi          | 176 ++++++++++++++++++
>  21 files changed, 527 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j132.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j137.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j140a.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j140k.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j152f.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j160.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j174.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j185.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j185f.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j213.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j214k.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j215.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j223.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j230k.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j680.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-j780.dts
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-jxxx.dtsi
>  create mode 100644 arch/arm64/boot/dts/apple/t8012-touchbar.dtsi
>  create mode 100644 arch/arm64/boot/dts/apple/t8012.dtsi
>
>
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> --
> 2.48.1
>
>

Series LGTM.

Reviewed-by: Neal Gompa <neal@xxxxxxxxx>


-- 
真実はいつも一つ！/ Always, there's only one truth!