Re: [PATCH] scripts: generate_rust_analyzer.py: add missing macros -> core dep
From: Miguel Ojeda
Date: Sun Feb 09 2025 - 12:22:00 EST
On Sun, Feb 9, 2025 at 6:09 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> The detailed reason why splitting host and target crates requires
> refactoring is that we currently we use `display_name` as a crate's
> unique identifier (i.e. both as a way of naming it as another crate's
> dependency, and as its name in the dependent crate). If we wanted to
> have separate target and host `core` crates we'd need a slightly more
> sophisticated way of describing dependencies. I'll work on this in a
> separate series.
Yeah, that is why I was wondering if it would be worth it or not, and
why I asked Lukas et al. (who leads rust-analyzer) if rust-analyzer is
OK with that to begin with (or what is the expected way to do this),
i.e. it may be that rust-analyzer does not "like" several crates with
the same `display_name`.
In any case, I would like to keep the complexity of the script low if
possible unless it really makes rust-analyzer understand the code
better etc.
Thanks!
Cheers,
Miguel