Re: [PATCH 01/12] cpufreq/amd-pstate: Remove the goto label in amd_pstate_update_limits
From: Gautham R. Shenoy
Date: Mon Feb 10 2025 - 00:12:41 EST
On Wed, Feb 05, 2025 at 11:25:12AM +0000, Dhananjay Ugwekar wrote:
> Scope based guard/cleanup macros should not be used together with goto
> labels. Hence, remove the goto label.
>
> Fixes: 6c093d5a5b73 ("cpufreq/amd-pstate: convert mutex use to guard()")
> Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@xxxxxxx>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>
--
Thanks and Regards
gautham.
> ---
> drivers/cpufreq/amd-pstate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 7120f035c0be..b163c1699821 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -838,8 +838,10 @@ static void amd_pstate_update_limits(unsigned int cpu)
> guard(mutex)(&amd_pstate_driver_lock);
>
> ret = amd_get_highest_perf(cpu, &cur_high);
> - if (ret)
> - goto free_cpufreq_put;
> + if (ret) {
> + cpufreq_cpu_put(policy);
> + return;
> + }
>
> prev_high = READ_ONCE(cpudata->prefcore_ranking);
> highest_perf_changed = (prev_high != cur_high);
> @@ -849,8 +851,6 @@ static void amd_pstate_update_limits(unsigned int cpu)
> if (cur_high < CPPC_MAX_PERF)
> sched_set_itmt_core_prio((int)cur_high, cpu);
> }
> -
> -free_cpufreq_put:
> cpufreq_cpu_put(policy);
>
> if (!highest_perf_changed)
> --
> 2.34.1
>