Re: [PATCH net-next v2] net: phy: marvell-88q2xxx: Add support for PHY LEDs on 88q2xxx

[Stefan Eichenberger]

Hi Dimitri,

On Sun, Feb 09, 2025 at 09:41:35AM +0100, Dimitri Fedrau wrote:
> Hi Stefan,
> 
> Am Sat, Feb 08, 2025 at 05:44:26PM +0100 schrieb Stefan Eichenberger:
> > On Fri, Feb 07, 2025 at 05:24:20PM +0100, Dimitri Fedrau wrote:
> > > Marvell 88Q2XXX devices support up to two configurable Light Emitting
> > > Diode (LED). Add minimal LED controller driver supporting the most common
> > > uses with the 'netdev' trigger.
> > > 
> > > Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
> > 
> > Reviewed-by: Stefan Eichenberger <eichest@xxxxxxxxx>
> > 
> 
> thanks for reviewing. I just noticed that led0 is enabled in
> mv88q222x_config_init, but I think it should be enabled in
> mv88q2xxx_config_init because LED configuration is same for all
> mv88q2xxx devices. What do you think ?

I think you are right. If you can move that to mv88q2xxx_config_init it
would be great. You can add my Reviewed-by tag to the updated patch.

Thanks,
Stefan