[PATCH net-next v2] af_unix: Fix undefined 'other' error

From: Purva Yeshi
Date: Mon Feb 10 2025 - 02:50:40 EST


Fix issue detected by smatch tool:
An "undefined 'other'" error occur in __releases() annotation.

Fix an undefined 'other' error in unix_wait_for_peer() caused by
__releases(&unix_sk(other)->lock) being placed before 'other' is in
scope. Since AF_UNIX does not use Sparse annotations, remove it to fix
the issue.

Eliminate the error without affecting functionality.

Signed-off-by: Purva Yeshi <purvayeshi550@xxxxxxxxx>
---
V1 - https://lore.kernel.org/lkml/20250209184355.16257-1-purvayeshi550@xxxxxxxxx/
V2 - Remove __releases() annotation as AF_UNIX does not use Sparse annotations.
net/unix/af_unix.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 34945de1f..319153850 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -1508,7 +1508,6 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr,
}

static long unix_wait_for_peer(struct sock *other, long timeo)
- __releases(&unix_sk(other)->lock)
{
struct unix_sock *u = unix_sk(other);
int sched;
--
2.34.1