Re: [PATCH v5 1/4] arm64: dts: rockchip: add overlay test for WolfVision PF5

[Dragan Simic]

Hello Quentin,

Please see a few comments below.

On 2025-02-07 16:19, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@xxxxxxxxx>
>
> The WolfVision PF5 can have a PF5 Visualizer display and PF5 IO 
> Expander
> board connected to it. Therefore, let's generate an overlay test so the
> application of the two overlays are validated against the base DTB.
>
> Suggested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
> Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile
> b/arch/arm64/boot/dts/rockchip/Makefile
> index
> def1222c1907eb16b23cff6d540174a4e897abc9..534e70a649eeada7f9b6f12596b83f5c47b184b4
> 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -170,3 +170,25 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += 
> rk3588s-orangepi-5.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
> +
> +# Overlay application tests
> +#
> +# A .dtbo must have its own
> +#
> +#  dtb-$(CONFIG_ARCH_ROCKCHIP) += <overlay>.dtbo
> +#
> +# entry, and at least one overlay application test - ideally 
> reflecting how it
> +# will be used in real life -:

Hmm, what's "-:" actually doing in the line right above?  I mean,
it's a minor nitpick, so might be worth addressing only if there
will be the v6...  Also, "test - ideally" might be replaced by
"test, ideally", because splicing sentences together using em/en
dashes is generally frowned upon. :)

> +#
> +#  dtb-$(CONFIG_ARCH_ROCKCHIP) += <name of overlay application 
> test>.dtb
> +#  <name of overlay application test>-dtbs := <base>.dtb
> <overlay-1>.dtbo [<overlay-2>.dtbo ...]

As another minor nitpick, I'd suggest that

    "<name of overlay application test>.dtb"

is replaced with

    "<name-of-overlay-application-test>.dtb"

for the sake of consistency and, obviously, for clear indication of
the space characters not being applicable.  Regarding using "-" or "_"
characters there, perhaps we should follow what Git uses in its man
pages, which is the "-" character (see e.g. git-switch(1)).

> +#
> +# This will make the <base>.dtb have symbols (like when DTC_FLAGS has
> -@ passed)
> +# and generate a new DTB (<name of overlay application test>.dtb) 
> which is the
> +# result of the application of <overlay-1>.dtbo and other listed
> overlays on top
> +# of <base>.dtb.
> +
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb
> +rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
> +	rk3568-wolfvision-pf5-display-vz.dtbo \
> +	rk3568-wolfvision-pf5-io-expander.dtbo

Otherwise, it's looking good to me, thanks for the patch!  It was
already discussed and commented in detail in the v4 of this series, [*]
so please feel free to include:

Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx>

[*] 
https://lore.kernel.org/linux-rockchip/a3b98e3d3a2571ee75e59418bb3b6960@xxxxxxxxxxx/T/#u