Re: [PATCH v3 2/2] counter: microchip-tcb-capture: Add capture extensions for registers RA-RC
From: Csókás Bence
Date: Mon Feb 10 2025 - 04:56:50 EST
Hi,
On 2025. 02. 07. 9:19, Dharma.B@xxxxxxxxxxxxx wrote:
The registers RA/B/C are 32 bit registers, hence use of u64 is unnecessary.
Correct, but the definition of COUNTER_COMP_ARRAY_CAPTURE
(include/linux/counter.h:623) is:
#define COUNTER_COMP_ARRAY_CAPTURE(_read, _write, _array) \
COUNTER_COMP_COUNT_ARRAY_U64("capture", _read, _write, _array)
The regmap_read() returns an error code, which is currently ignored. If
regmap_read() fails, cnt remains uninitialized, potentially returning
garbage data.
Will fix.
Thanks,
Bence