Re: [PATCH v2 1/2] slab: Adjust placement of __kvmalloc_node_noprof
From: Vlastimil Babka
Date: Mon Feb 10 2025 - 04:59:28 EST
On 2/8/25 02:47, GONG Ruiqi wrote:
> Move __kvmalloc_node_noprof (and also kvfree* for consistency) into
> mm/slub.c so that it can directly invoke __do_kmalloc_node, which is
> needed for the next patch. Move kmalloc_gfp_adjust to slab.h since now
> its two callers are in different .c files.
>
> No functional changes intended.
>
> Signed-off-by: GONG Ruiqi <gongruiqi1@xxxxxxxxxx>
> ---
> include/linux/slab.h | 22 +++++++++
> mm/slub.c | 90 ++++++++++++++++++++++++++++++++++
> mm/util.c | 112 -------------------------------------------
> 3 files changed, 112 insertions(+), 112 deletions(-)
>
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 09eedaecf120..0bf4cbf306fe 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
This could be mm/slab.h instead.
But I'd just go all the way and move kvrealloc_noprof() too, it would be
more consistent anyway.