Re: [PATCH v2 2/3] rust: configfs: introduce rust support for configfs

[Andreas Hindborg]

"Charalampos Mitrodimas" <charmitro@xxxxxxxxxx> writes:

> Andreas Hindborg <a.hindborg@xxxxxxxxxx> writes:
>
>> This patch adds a rust API for configfs, thus allowing rust modules to use
>> configfs for configuration. The implementation is a shim on top of the C
>> configfs implementation allowing safe use of the C infrastructure from
>> rust.
>>
>> The patch enables the `const_mut_refs` feature on compilers before rustc
>> 1.83. The feature was stabilized in rustc 1.83 and is not required to be
>> explicitly enabled on later versions.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
>>

[...]

>
> Tested-by: Charalampos Mitrodimas <charmitro@xxxxxxxxxx>

Thanks for testing!

>
> One minor nit, "4096" is mentioned a lot in the sample, which is normal,
> should we have it as PAGE_SIZE (from kernel::page)?

Yes, I forgot. I will fix that.


Best regards,
Andreas Hindborg