Re: [PATCH] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4

[AngeloGioacchino Del Regno]

Il 07/02/25 14:54, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Sinovoip has released other variants of Bananapi-R4 board.
> The known changes affecting only the LAN SFP+ slot which is replaced
> by a 2.5G phy with optional PoE.
>
> As the SFP-Ports are not upstreamed yet this patch simply renames the
> current board dts to dtsi, creating new dts for the board including
> the new dtsi and move i2c-mux channel for sfp lan to board dts.
>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

I understand what's going on, and I agree, but this change alone doesn't make a lot
of sense, does it?

If I were to see a commit that moves everything in a dtsi, and justifies that by
adding two dts for the two variants, though, things would be different.... :-)

Cheers,
Angelo

> ---
>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  | 404 +-----------------
>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 403 +++++++++++++++++
>   2 files changed, 407 insertions(+), 400 deletions(-)
>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi