Re: [PATCH RFC net-next] net: Add dev_getbyhwaddr_rtnl() helper

[Breno Leitao]

Hello Jakub,

On Fri, Feb 07, 2025 at 04:27:18PM -0800, Jakub Kicinski wrote:
> On Fri, 07 Feb 2025 04:11:34 -0800 Breno Leitao wrote:
> > +static bool dev_comp_addr(struct net_device *dev,
> > +			  unsigned short type,
> > +			  const char *ha)

> static bool dev_comp_addr(struct net_device *dev, unsigned short type,
> 			  const char *ha)

This one aligns better with the other functions in the file. Example:

  struct net_device *dev_getbyhwaddr_rcu(struct net *net, unsigned short type,
                                         const char *ha)

> > + */
> > +struct net_device *dev_getbyhwaddr_rtnl(struct net *net, unsigned short type,
> > +					const char *ha)
> 
> You missed adding this to a header file?

Yes. NIPA caught this one beautifully:

	https://patchwork.kernel.org/project/netdevbpf/patch/20250207-arm_fix_selftest-v1-1-487518d2fd1c@xxxxxxxxxx/

I will send a v2 soon,

Thanks for the review
--breno