Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

From: Heiko Stübner
Date: Mon Feb 10 2025 - 07:07:57 EST


Am Montag, 10. Februar 2025, 12:06:15 MEZ schrieb Krzysztof Kozlowski:
> On 07/02/2025 12:11, Diederik de Haas wrote:
> > Add the recommended chassis-type root node property so userspace can
> > request the form factor and adjust their behavior accordingly.
> >
> > Signed-off-by: Diederik de Haas <didi.debian@xxxxxxxxx>
> > Link: https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node
>
> Drop link, no need to point to source of every property. You don't do it
> for aliases, compatible, model etc, right?
>
> With link dropped:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

I've amended the patch [0] by dropping the Link and adding Krzysztof's
Reviewed-by.


Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=aba881f30e0294a58c0cb076918d366e39801185