Re: [PATCH v3 06/28] mm/hugetlb: remove redundant __ClearPageReserved

[Oscar Salvador]

On Thu, Feb 06, 2025 at 06:50:46PM +0000, Frank van der Linden wrote:
> In hugetlb_folio_init_tail_vmemmap, the reserved flag is cleared for
> the tail page just before it is zeroed out, which is redundant.
> Remove the __ClearPageReserved call.
> 
> Signed-off-by: Frank van der Linden <fvdl@xxxxxxxxxx>

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

> ---
>  mm/hugetlb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 1d8ec21dc2c2..0836e3231774 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3202,7 +3202,6 @@ static void __init hugetlb_folio_init_tail_vmemmap(struct folio *folio,
>  	for (pfn = head_pfn + start_page_number; pfn < end_pfn; pfn++) {
>  		struct page *page = pfn_to_page(pfn);
>  
> -		__ClearPageReserved(folio_page(folio, pfn - head_pfn));
>  		__init_single_page(page, pfn, zone, nid);
>  		prep_compound_tail((struct page *)folio, pfn - head_pfn);
>  		ret = page_ref_freeze(page, 1);
> -- 
> 2.48.1.502.g6dc24dfdaf-goog
> 
> 

-- 
Oscar Salvador
SUSE Labs