Re: [PATCH v2 1/2] dmaengine: Use str_enable_disable-like helpers
From: Vinod Koul
Date: Mon Feb 10 2025 - 09:37:03 EST
On Tue, 14 Jan 2025 20:10:20 +0100, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read. Ternary
> operator has three arguments and with wrapping might lead to quite
> long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
> file.
>
> [...]
Applied, thanks!
[1/2] dmaengine: Use str_enable_disable-like helpers
commit: 8e63891831f3904047d7ad8078ff52dd454b6975
[2/2] dmaengine: pxa: Enable compile test
commit: 9fc2f03e85952ee52558ab844473a8284d924a56
Best regards,
--
~Vinod