Re: [RFC v2 18/38] docs: sphinx/kernel_abi: use AbiParser directly
From: Jonathan Corbet
Date: Mon Feb 10 2025 - 09:40:19 EST
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:
> I took a look on Markus work: it was licensed under GPL 3.0 and it was
> written in 2016. There were several changes on kerneldoc since them,
> including the addition of a regex that it is not compatible with
> Python re[1]:
>
> $members =~ s/\bSTRUCT_GROUP(\(((?:(?>[^)(]+)|(?1))*)\))[^;]*;/$2/gos;
>
> This one use:
>
> - recursive patterns: ?1
> - atomic grouping (?>...)
>
> Also, it is hard to map what he does with the existing script. I'm
> opting to write a new script from scratch.
That's fine, I just wanted to be sure you'd had a chance to look at
it...
> Another option would be to re-implement such regexes without using
> such advanced patterns.
Seems like a preferred option if that can be done. Banging one's head
against all those regexes is often the hardest part of dealing with that
script; anything that makes it simpler is welcome.
Thanks,
jon