Re: [PATCH 5/5] hwmon: (gpio-fan) Add regulator support

From: Mark Brown
Date: Mon Feb 10 2025 - 10:29:08 EST


On Mon, Feb 10, 2025 at 03:59:33PM +0100, Alexander Stein wrote:

> + fan_data->supply = devm_regulator_get_optional(dev, "fan");
> + if (IS_ERR(fan_data->supply)) {
> + err = PTR_ERR(fan_data->supply);

Unless fans are expected to operate without power (which does seem
unlikely) the supply should really be mandatory.

Attachment: signature.asc
Description: PGP signature