RE: [PATCH v2 net-next 1/2] net: mana: Allow tso_max_size to go up-to GSO_MAX_SIZE
From: Haiyang Zhang
Date: Mon Feb 10 2025 - 10:42:31 EST
> -----Original Message-----
> From: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> Sent: Sunday, February 9, 2025 11:40 PM
> To: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Wei Liu
> <wei.liu@xxxxxxxxxx>; Dexuan Cui <decui@xxxxxxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Long Li <longli@xxxxxxxxxxxxx>; Konstantin
> Taranov <kotaranov@xxxxxxxxxxxxx>; Souradeep Chakrabarti
> <schakrabarti@xxxxxxxxxxxxxxxxxxx>; Erick Archer
> <erick.archer@xxxxxxxxxxx>; Shradha Gupta <shradhagupta@xxxxxxxxxxxxx>
> Subject: [PATCH v2 net-next 1/2] net: mana: Allow tso_max_size to go up-
> to GSO_MAX_SIZE
>
> Allow the max aggregated pkt size to go up-to GSO_MAX_SIZE for MANA NIC.
> This patch only increases the max allowable gso/gro pkt size for MANA
> devices and does not change the defaults.
> Following are the perf benefits by increasing the pkt aggregate size from
> legacy gso_max_size value(64K) to newer one(up-to 511K)
>
> for i in {1..10}; do netperf -t TCP_RR -H 10.0.0.5 -p50000 -- -
> r80000,80000
> -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT|tail -1; done
>
> min p90 p99 Throughput gso_max_size
> 93 171 194 6594.25
> 97 154 180 7183.74
> 95 165 189 6927.86
> 96 165 188 6976.04
> 93 154 185 7338.05 64K
> 93 168 189 6938.03
> 94 169 189 6784.93
> 92 166 189 7117.56
> 94 179 191 6678.44
> 95 157 183 7277.81
>
> min p90 p99 Throughput
> 93 134 146 8448.75
> 95 134 140 8396.54
> 94 137 148 8204.12
> 94 137 148 8244.41
> 94 128 139 8666.52 80K
> 94 141 153 8116.86
> 94 138 149 8163.92
> 92 135 142 8362.72
> 92 134 142 8497.57
> 93 136 148 8393.23
>
> Tested on azure env with Accelerated Networking enabled and disabled.
>
> Signed-off-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>