Re: [PATCH v2] x86/fpu: make WARN_ON_FPU get fully optimized out

[Eric Biggers]

On Mon, Jan 27, 2025 at 02:45:23PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Currently WARN_ON_FPU evaluates its argument even if
> CONFIG_X86_DEBUG_FPU is disabled, which adds unnecessary instructions to
> several functions, for example kernel_fpu_begin().  Fix this by using
> BUILD_BUG_ON_INVALID(x) in the no-debug case rather than (void)(x).
> 
> Fixes: 83242c515881 ("x86/fpu: Make WARN_ON_FPU() more robust in the !CONFIG_X86_DEBUG_FPU case")
> Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
> 
> v2: use BUILD_BUG_ON_INVALID() as suggested by Sean Christopherson.
> 
>  arch/x86/kernel/fpu/internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping.  Any interest in taking this through the x86 tree?

- Eric