Re: [PATCH v2] scripts: generate_rust_analyzer.py: add missing macros deps

From: Fiona Behrens
Date: Mon Feb 10 2025 - 12:01:04 EST


Tamir Duberstein <tamird@xxxxxxxxx> writes:

> On Mon, Feb 10, 2025 at 11:32 AM Fiona Behrens <me@xxxxxxxxxx> wrote:
>>
>> Competing with https://lore.kernel.org/rust-for-linux/20241205115438.234221-1-me@xxxxxxxxxx/
>> but I do like your aproach more.
>
> Missed this one go by. Sorry!

No worries at all, was mostly also to make sure that not both gets merged.

>
>> Reviewed-by: Fiona Behrens <me@xxxxxxxxxx>
>
> Thanks for reviewing! I'm going to respin v3 that looks a little bit
> more like https://lore.kernel.org/all/20250209-rust-analyzer-host-v1-3-a2286a2a2fa3@xxxxxxxxx/
> which is the proper fix. If you're OK with it, I'll keep your tag.

Sure, feel also free to ping on zullip if anything specific before
sending. But your code already looks very good. Like it with the types
and such.

Thanks
Fiona