Re: [PATCH v1] tools build: Fix a number of Wconversion warnings

From: Ian Rogers
Date: Mon Feb 10 2025 - 13:22:39 EST


On Mon, Jan 6, 2025 at 1:54 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> There's some expressed interest in having the compiler flag
> -Wconversion detect at build time certain kinds of potential problems:
> https://lore.kernel.org/lkml/20250103182532.GB781381@xxxxxxxxxxxxxxx/
>
> As feature detection passes -Wconversion from CFLAGS when set, the
> feature detection compile tests need to not fail because of
> -Wconversion as the failure will be interpretted as a missing
> feature. Switch various types to avoid the -Wconversion issue, the
> exact meaning of the code is unimportant as it is typically looking
> for header file definitions.
>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Ping. Also:
Reviewed-by: James Clark <james.clark@xxxxxxxxxx>
Would be nice to be cleaner wrt compiler warnings.

Thanks,
Ian