Re: [PATCH net-next v3 09/15] mptcp: pm: make three pm wrappers static

From: Simon Horman
Date: Mon Feb 10 2025 - 14:52:08 EST


On Fri, Feb 07, 2025 at 02:59:27PM +0100, Matthieu Baerts (NGI0) wrote:
> From: Geliang Tang <tanggeliang@xxxxxxxxxx>
>
> Three netlink functions:
>
> mptcp_pm_nl_get_addr_doit()
> mptcp_pm_nl_get_addr_dumpit()
> mptcp_pm_nl_set_flags_doit()
>
> are generic, implemented for each PM, in-kernel PM and userspace PM. It's
> clearer to move them from pm_netlink.c to pm.c.
>
> And the linked three path manager wrappers
>
> mptcp_pm_get_addr()
> mptcp_pm_dump_addr()
> mptcp_pm_set_flags()
>
> can be changed as static functions, no need to export them in protocol.h.
>
> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>