Re: [PATCH] hrtimers: Make hrtimer_update_function() less expensive
From: Jens Axboe
Date: Mon Feb 10 2025 - 14:56:16 EST
On 2/10/25 12:52 PM, Thomas Gleixner wrote:
> On Sat, Feb 08 2025 at 08:18, Jens Axboe wrote:
>
>> On 2/7/25 2:16 PM, Thomas Gleixner wrote:
>>> The sanity checks in hrtimer_update_function() are expensive for high
>>> frequency usage like in the io/uring code due to locking.
>>>
>>> Hide the sanity checks behind CONFIG_PROVE_LOCKING, which has a decent
>>> chance to be enabled on a regular basis for testing.
>>
>> Looks good to me, thanks Thomas. On my side, I always have a debug run
>> done with PROVE_LOCKING and KASAN, fwiw.
>
> I assume that with that your objections against the conversion of ioring
> to hrtimer_update_function() is gone too.
Certainly, with the expensive bits under PROVE_LOCKING, I have no
objections to the patch.
--
Jens Axboe