Re: [PATCH RESEND v2 1/2] block: introduce init_wait_func()

From: Tejun Heo
Date: Mon Feb 10 2025 - 16:07:46 EST


On Sat, Feb 08, 2025 at 05:04:15PM +0800, Muchun Song wrote:
> There is already a macro DEFINE_WAIT_FUNC() to declare a wait_queue_entry
> with a specified waking function. But there is not a counterpart for
> initializing one wait_queue_entry with a specified waking function. So
> introducing init_wait_func() for this, which also could be used in iocost
> and rq-qos. Using default_wake_function() in rq_qos_wait() to wake up
> waiters, which could remove ->task field from rq_qos_wait_data.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

For rq-qos / blk-iocost part:

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun