Re: [PATCH V5] phy: freescale: fsl-samsung-hdmi: fix build error in fsl_samsung_hdmi_phy_configure_pll_lock_det

[Pei Xiao]

在 2025/2/11 01:02, Vinod Koul 写道:
> On 17-01-25, 10:15, Pei Xiao wrote:
>> 在 2025/1/17 09:59, Adam Ford 写道:
>>> On Mon, Jan 13, 2025 at 2:41 AM <xiaopeitux@xxxxxxxxxxx> wrote:
>>>> From: Pei Xiao <xiaopei01@xxxxxxxxxx>
>>>>
>>>> FIELD_PREP() checks that a value fits into the available bitfield,
>>>> but the index div equals to 4,is out of range.
>>>>
>>>> which gcc complains about:
>>>> In function ‘fsl_samsung_hdmi_phy_configure_pll_lock_det’,
>>>> inlined from ‘fsl_samsung_hdmi_phy_configure’ at
>>>> drivers/phy/freescale/phy-fsl-samsung-hdmi.c :470:2:
>>>> ././include/linux/compiler_types.h:542:38: error: call to ‘__compiletime_assert_538’
>>>> declared with attribute error: FIELD_PREP: value too large for the field
>>>>   542 |  _compiletime_assert(condition, msg, __compiletime_assert_,
>>>> __COUNTER__)
>>>>       |                                      ^
>>>> ././include/linux/compiler_types.h:523:4: note: in definition of
>>>> macro ‘__compiletime_assert’ 523 |    prefix ## suffix();
>>>>       |    ^~~~~~
>>>> ././include/linux/compiler_types.h:542:2: note: in expansion of macro
>>>> ‘_compiletime_assert’
>>>>   542 |  _compiletime_assert(condition, msg, __compiletime_assert_,
>>>>  __COUNTER__)
>>>>
>>>> REG12_CK_DIV_MASK only two bit, limit div to range 0~3,
>>>> so build error will fix.
>>>>
>>> LGTM.
>>>
>>> Reviewed-by:  Adam Ford <aford173@xxxxxxxxx>
>> loop Vkoul for email address was written incorrectly.
> Thanks for looping in!
>
> Change looks good to me. Can you please revise the patch title. A patch
> title should describe the change we are making. Fix build error is not
> an apt title

there so many  "Fix build error" : https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?qt=grep&q=fix+build+error

what we should revise?

Like:*phy: freescale: fsl-samsung-hdmi: Limit PLL lock detection clock divider to valid range*

if you approve,I will send V6 for the title,or any advice?

Pei,

Thanks!