Re: [PATCH net-next] documentation: networking: Add NAPI config

[Randy Dunlap]

On February 10, 2025 6:16:35 PM PST, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>On Sat,  8 Feb 2025 01:28:21 +0000 Joe Damato wrote:
>> +Persistent NAPI config
>> +----------------------
>> +
>> +Drivers can opt-in to using a persistent NAPI configuration space by calling
>
>Should we be more forceful? I think for new drivers the _add_config() 
>API should always be preferred given the benefits.
>
>> +netif_napi_add_config. This API maps a NAPI instance to a configuration
>> +structure using a driver defined index value, like a queue number. If the
>> +driver were to destroy and recreate NAPI instances (if a user requested a queue
>
>"were" is correct here?

Yes, subjunctive mood.


>> +count change, for example), the new NAPI instances will inherit the configuration
>> +settings of the NAPI configuration structure they are mapped to.
>


~Randy