RE: [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq to mce_early_notifier()

From: Zhuo, Qiuxu
Date: Tue Feb 11 2025 - 02:10:31 EST


> From: Nikolay Borisov <nik.borisov@xxxxxxxx>
> [...]
> Subject: [PATCH v2 2/3] x86/mce: Move message printing from mce_notify_irq
> to mce_early_notifier()
>
> Informing the user that an MCE has been logged from mce_notify_irq() is
> somewhat misleading because whether the MCE has been logged actually
> depends on whether CONFIG_X86_MCELOG_LEGACY is turned on or not.
>
> Furthermore it was reported that actually having a message triggered when
> an MCE is generated can be helpful in certain scenarios. Improve the situation
> by lifting the printing to the generic
> mce_early_notifier() as it's executed always and is independent of any
> compile-time option.
>
> Link:
> https://lore.kernel.org/all/CY8PR11MB7134D97F82DC001AE009637889E32@
> CY8PR11MB7134.namprd11.prod.outlook.com/
> Signed-off-by: Nikolay Borisov <nik.borisov@xxxxxxxx>

LGTM. Thanks!

Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>