Re: [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization

[Jonathan Cameron]

On Tue, 11 Feb 2025 14:20:54 +0800
Li Ming <ming.li@xxxxxxxxxxxx> wrote:

> gp_port is already pointed to the grandparent port during its definition,
> remove a redundant code to let gp_port point to the grandparent port
> again.
> 
> Signed-off-by: Li Ming <ming.li@xxxxxxxxxxxx>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
>  drivers/cxl/core/cdat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index 8153f8d83a16..c656c1346aa0 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -651,7 +651,6 @@ static int cxl_endpoint_gather_bandwidth(struct cxl_region *cxlr,
>  	if (IS_ERR(perf))
>  		return PTR_ERR(perf);
>  
> -	gp_port = to_cxl_port(parent_port->dev.parent);
>  	*gp_is_root = is_cxl_root(gp_port);
>  
>  	/*