Re: [PATCH v2 4/6] drivers: usb: serial: mos7840: using '__func__' to replace function name in dbg message

[Johan Hovold]

On Fri, Oct 25, 2024 at 02:17:14PM +0800, Tony Chung wrote:
> fix warning of Prefer '"%s...",__func__' to using 'function name'.
> 
> Signed-off-by: Tony Chung <tony467913@xxxxxxxxx>
> ---
>  drivers/usb/serial/mos7840.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index b48a26468..31ec2cf1b 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -230,7 +230,7 @@ static int mos7840_set_reg_sync(struct usb_serial_port *port, __u16 reg,
>  	struct usb_device *dev = port->serial->dev;
>  
>  	val = val & 0x00ff;
> -	dev_dbg(&port->dev, "mos7840_set_reg_sync offset is %x, value %x\n", reg, val);
> +	dev_dbg(&port->dev, "%s offset is %x, value %x\n", __func__, reg, val);

I suggest you just leave this as is.

Johan