Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
From: Crystal Guo (郭晶)
Date: Tue Feb 11 2025 - 06:25:23 EST
On Sun, 2025-02-09 at 11:48 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 06/02/2025 13:16, Crystal Guo wrote:
> > A MediaTek DRAM controller interface to provide the current DDR
> > data rate.
>
> Please wrap commit message according to Linux coding style /
> submission
> process (neither too early nor over the limit):
>
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst*L597__;Iw!!CTRNKA9wMg0ARbw!lrJR1xYY1zrw1dRnvzwOsd0FyqQawTURFAKVFpWEaMLN2eiV03gQy8WDacH-ZGIypB4-WuPupcOERlw9$
>
>
> >
> > Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx>
> > ---
> > .../mediatek,common-dramc.yaml | 129 --------------
> > ----
>
> Why is there removal here if you add? Commit msg explains nothing
> here.
>
> Why this patch was sent twice?
>
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch -vX` helps here to create proper versioned
> patches. Another useful tool is b4. Skipping the PATCH keyword makes
> filtering of emails more difficult thus making the review process
> less
> convenient.
>
> Best regards,
> Krzysztof
This patch was based on the previous version.
But the approach was actually incorrect (shall NOT be patches on the
top of the previous version), so I have resent the new v2 patches based
on a clean kernel.
Thanks
Crystal