Re: [PATCH RFC v2 1/5] dt-bindings: thermal: Add MBG thermal monitor support
From: Krzysztof Kozlowski
Date: Tue Feb 11 2025 - 06:48:35 EST
On 11/02/2025 12:15, Satya Priya Kakitapalli wrote:
>
> On 12/13/2024 2:08 PM, Krzysztof Kozlowski wrote:
>> On Thu, Dec 12, 2024 at 09:41:20PM +0530, Satya Priya Kakitapalli wrote:
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - interrupts
>>> + - io-channels
>>> + - io-channel-names
>> Binding looks ok, but this wasn't tested due to unneeded dependency.
>> Please decouple from dependency, so automation can properly test it.
>
>
> The dependency is needed because this mbg peripheral is present on only
> targets which have GEN3 ADC5, for which the bindings support is added in
> the series [1]
>
>
> [1]
> https://lore.kernel.org/linux-arm-msm/c4ca0a4c-e421-4cf6-b073-8e9019400f4c@xxxxxxxxxxx/
Sure. Then this cannot be merged due to resulting test failure.
Please don't post new versions before this can be actually tested and
applied.
Best regards,
Krzysztof