Re: [PATCH net-next v2 2/2] net: Add dev_getbyhwaddr_rtnl() helper

From: Iwashima, Kuniyuki
Date: Tue Feb 11 2025 - 06:50:41 EST


From: Breno Leitao <leitao@xxxxxxxxxx>
Date: Tue, 11 Feb 2025 03:36:43 -0800
> > > +struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type,
> > > + const char *ha)
> > > +{
> > > + struct net_device *dev;
> > > +
> > > + ASSERT_RTNL();
> > > + for_each_netdev(net, dev)
> > > + if (dev_comp_addr(dev, type, ha))
> > > + return dev;
> > > +
> > > + return NULL;
> > > +}
> > > +EXPORT_SYMBOL(dev_getbyhwaddr);
> >
> > Commit title should change to reflect the new function name in v2.
> >
> > Separately - how should I combine this with
> > https://lore.kernel.org/netdev/20250205-netconsole-v3-0-132a31f17199@xxxxxxxxxxxxxxx/?
> > I see three options:
> > - combine the two series into one
>
> I would suggest you combine the two series into one.
>
> I will send a v3 today adjusting the comments, and you can integrated
> them into your patchset.

I suggest Breno post v3 for net.git with arp fix and then net.git
will be merged to net-next on Thursday, then Uday can respin.

If this is posted to net-next.git, the following arp fix needs to
wait for the next cycle so that net-next.git will be merged to
net.git.