Re: [PATCH v8 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc

From: Krzysztof Kozlowski
Date: Tue Feb 11 2025 - 07:05:41 EST


On 11/02/2025 13:02, André Draszik wrote:
> Hi Tudor,
>
> On Tue, 2025-02-11 at 11:57 +0000, Tudor Ambarus wrote:
>> And then I shall s/MODULE_LICENSE("GPL");/MODULE_LICENSE("GPL v2");/
>> everywhere as "GPL" indicates [GNU Public License v2 or later].
>
> No, please don't, see Documentation/process/license-rules.rst.
For the rest of suggestions here I also recommend rereading docs. I
don't get why we need to change "GPL-2.0 OR BSD-2-Clause", but maybe I
miss some docs. Whatever SPDX recommends is irrelevant if kernel
recommends for example something else, so be sure you make it aligned
with actual kernel preference.

Best regards,
Krzysztof