Re: [PATCH 11/14] cpufreq/amd-pstate: Drop debug statements for policy setting

From: Dhananjay Ugwekar
Date: Tue Feb 11 2025 - 08:03:50 EST


On 2/7/2025 3:26 AM, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@xxxxxxx>
>
> There are trace events that exist now for all amd-pstate modes that
> will output information right before programming to the hardware.
>
> This makes the existing debug statements unnecessary remaining
> overhead. Drop them.

Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@xxxxxxx>

Thanks,
Dhananjay

>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> drivers/cpufreq/amd-pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 754f2d606b371..689de385d06da 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -673,7 +673,6 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data)
> }
>
> cpufreq_verify_within_cpu_limits(policy_data);
> - pr_debug("policy_max =%d, policy_min=%d\n", policy_data->max, policy_data->min);
>
> return 0;
> }
> @@ -1652,9 +1651,6 @@ static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy)
> if (!policy->cpuinfo.max_freq)
> return -ENODEV;
>
> - pr_debug("set_policy: cpuinfo.max %u policy->max %u\n",
> - policy->cpuinfo.max_freq, policy->max);
> -
> cpudata->policy = policy->policy;
>
> ret = amd_pstate_epp_update_limit(policy);