Re: [PATCH v6 1/2] scanf: convert self-test to KUnit

[Tamir Duberstein]

On Tue, Feb 11, 2025 at 7:15 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Feb 11, 2025 at 06:45:07AM -0500, Tamir Duberstein wrote:
> > On Tue, Feb 11, 2025 at 6:37 AM Petr Mladek <pmladek@xxxxxxxx> wrote:
> > > On Mon 2025-02-10 13:13:48, Tamir Duberstein wrote:
>
> > > > +     kunit_printk(KERN_DEBUG, test, "\"%s\", \"%s\" ->", str, fmt);  \
> > >
> > > The switch from pr_debug() to kunit_printk() causes printing huge
> > > amount of messages even when the test passes.
> >
> > I'm not able to reproduce this. pr_debug expands to printk(KERN_DEBUG,
> > ...) which is also what kunit_printk(KERN_DEBUG, ...) expands to. Can
> > you help me understand how you're testing?
>
> You are missing something.
> https://stackoverflow.com/a/57762255/2511795
>
> --
> With Best Regards,
> Andy Shevchenko
>

I see. Given Petr's comment about pr_debug also not being the right
thing, I took a closer look and realized that these debug logs are
redundant as they don't provide any information beyond what the
failure messages already do. So I'll just remove them.