Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

[Danilo Krummrich]

On Tue, Feb 11, 2025 at 12:14:23PM +0100, Philipp Stanner wrote:
> drm_sched_init() has a great many parameters and upcoming new
> functionality for the scheduler might add even more. Generally, the
> great number of parameters reduces readability and has already caused
> one missnaming, addressed in:
> 
> commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in
> nouveau_sched_init()").
> 
> Introduce a new struct for the scheduler init parameters and port all
> users.
> 
> Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>
> Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
> Acked-by: Matthew Brost <matthew.brost@xxxxxxxxx> # for Xe
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> # for Panfrost and Panthor
> Reviewed-by: Christian Gmeiner <cgmeiner@xxxxxxxxxx> # for Etnaviv
> Reviewed-by: Frank Binns <frank.binns@xxxxxxxxxx> # for Imagination
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx> # for Sched
> Reviewed-by: Maíra Canal <mcanal@xxxxxxxxxx> # for v3d

Reviewed-by: Danilo Krummrich <dakr@xxxxxxxxxx>