Re: [PATCH v10 07/14] platform/x86: alienware-wmi: Split DMI table

[Andy Shevchenko]

On Fri, Feb 07, 2025 at 10:46:03AM -0500, Kurt Borja wrote:
> Split thermal features into a new DMI table to support upcoming file
> split. While at it:
> 
> Rename quirk_entry -> alienfx_quirks,
> Rename quirks -> alienfx
> 
> and change hdmi_mux, amplifier and deepslp types to bool, because they are
> already being implicitly used as bools.

...

> +struct awcc_quirks {
> +	bool pprof;
> +	bool gmode;

Wouldn't it be better to have them as bitfields?

	unsigned int pprof:1;
	...

On 5th quirk (if ever happens) this will gain memory.

> +};

-- 
With Best Regards,
Andy Shevchenko