Re: [PATCH v10 10/14] platform/x86: Add alienware-wmi.h

[Andy Shevchenko]

On Tue, Feb 11, 2025 at 06:51:03PM +0200, Ilpo Järvinen wrote:
> On Tue, 11 Feb 2025, Andy Shevchenko wrote:
> > On Fri, Feb 07, 2025 at 10:46:06AM -0500, Kurt Borja wrote:
> > > Add a header file for alienware-wmi with shared resources to support the
> > > upcoming file split.

...

> > >  static const struct attribute_group *alienfx_groups[] = {
> > >  	&zone_attribute_group,
> > > -	&hdmi_attribute_group,
> > > -	&amplifier_attribute_group,
> > > -	&deepsleep_attribute_group,
> > > +	WMAX_DEV_GROUPS
> > >  	NULL
> > 
> > I don't like this change as it makes code harder to understand (at one glance
> > you can't answer the question "what are the groups that being listed here?".
> 
> Over having #ifdeffery here, I've no problem whatsoever with it (and in 
> fact I suggested goingthis way). It's pretty much boilerplate anyway 
> having to list them yet in another place.

As I said in the reply to the cover letter subthread this is not my main
concern anyway. Let it be then.

-- 
With Best Regards,
Andy Shevchenko