Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family driver

From: Jiri Slaby
Date: Tue Feb 11 2025 - 12:40:29 EST


On 11. 02. 25, 13:44, Stuart wrote:
E.g. set_bit() (one bit per OP) to something like 'unsigned long flags'
in 'struct corsair_void_drvdata'. But it depends if you want to preserve
order of actions... (Which was not guaranteed with separate queues
anyway, so I assume not?)

Wouldn't using one variable for the flags risk overwriting each other, unless
it was atomic? I might be misunderstanding, I haven't played with the kernel's
work much.

set/clear/test/test_and_clear/..._bit() are guaranteed to be atomic.

--
js
suse labs